threepenny-gui icon indicating copy to clipboard operation
threepenny-gui copied to clipboard

Update Electron

Open bradrn opened this issue 3 years ago • 6 comments

threepenny-gui’s recommended package.json uses Electron version ^1.6.1. By contrast, the Electron quickstart package.json uses Electron version ^10.1.3 — nine major versions later! It looks like threepenny-gui desperately needs to upgrade its Electron version. To do this, the package versions in package.json would need to be upgraded; after that the provided electron.js will probably need to be changed as well, in order to keep it working with the updated package versions.

(This seems like a simple change, and I would submit a PR myself, except that (a) my knowledge of the node.js ecosystem is practically nonexistent, and (b) I cannot build threepenny-gui, and thus am unable to test any changes I may make. If by some miracle I manage to get everything working again, I can certainly try to submit a PR for this, but until then I can’t really do anything with threepenny-gui.)

bradrn avatar Sep 30 '20 13:09 bradrn

Unfortunately I'm also quite unfamiliar with Electron and the node ecosystem. I'd appreciate a PR!

sjakobi avatar Oct 01 '20 12:10 sjakobi

Hi! May I work on this issue?

adi-mohan avatar Oct 25 '20 06:10 adi-mohan

Also, you should almost never use electron in dependencies. It should be under devDependencies, reason being electron is not advised to install on production environment. I will initiate PR, whenever you respond to this. @bradrn @HeinrichApfelmus @sjakobi

adi-mohan avatar Oct 25 '20 07:10 adi-mohan

I’d be happy for you to work on this issue, although it would be nice to have some comment from @HeinrichApfelmus on whether that’s OK (which I assume it is).

bradrn avatar Oct 25 '20 07:10 bradrn

@adi-mohan Yes, please! I'm not very familiar with the npm ecosystem, so any help is appreciated.

HeinrichApfelmus avatar Oct 25 '20 12:10 HeinrichApfelmus

Update on this issue: I’ve been working recently on a threepenny-gui application in Electron, and I think I’ve managed to get it working with the latest versions of everything. I’d like to do a rewrite of the existing tutorial to get it a bit more up-to-date, but I think I’ll just wait a bit until I’m confident I’ve gotten everything working properly.

bradrn avatar Feb 07 '21 04:02 bradrn