HearthSim
[Secret Logic] Incorrect exclusion logic regarding Fyrakk generated spells and Dormant minions
Game mode
- [x ] Standard
- [ x] Wild
- [ ] Classic
- [ ] Arena
- [ ] Battlegrounds
- [ ] Duels
- [ ] Mercenaries
- [ ] Tavern Brawl
- [ ] Dungeon Run/Book of Heroes/Book of Mercenaries
- [ ] Single Player
Description
I have identified two logic issues regarding Secret exclusions in the tracker. I would like to report them and propose a fix.
- Fyrakk the Blazing and Fire Spells
Scenario: When Fyrakk the Blazing is played, it excutes with Fire spells. Issue: If the opponent plays a Secret that was generated by Fyrakk, the tracker currently does not seem to respect the "Fire" attribute constraint. Expected Behavior: Since Fyrakk only generates Fire spells, if a generated Secret is played, the tracker should immediately exclude all non-Fire Secrets (e.g., Counterspell, Ice Barrier) and only display Fire-school Secrets (e.g., Explosive Runes, Vaporize) as possibilities.
- Explosive Runes interaction with Dormant Minions
Scenario: When a minion that enters play in a Dormant state (e.g. like the "Ancient of Yore") is played. Issue: Currently, if the Secret does not trigger on a Dormant minion, the tracker incorrectly rules out Explosive Runes. Expected Behavior: Due to the specific mechanics of Dormant minions preventing certain triggers or targeting, Explosive Runes should NOT be excluded from the list of possible secrets just because it didn't trigger on a Dormant minion. It remains a valid possibility for the active secret.
Proposal & Request for Assignment
Hi, I am a university student currently taking a course on Open Source Software Design.
Disclaimer: Due to heavy academic research commitments recently, my last active gameplay of Hearthstone was on November 1st. I am unsure if these specific issues have been resolved in patches released since then. If they have already been fixed, I sincerely apologize for the disturbance.
As part of my final coursework, I am required to contribute to an open-source project by fixing bugs or implementing features. I am very interested in fixing the logic issues described above.
Could you please assign this issue to me?
I kindly ask for a 2-week window to work on this.
- If I submit a Pull Request within 2 weeks, I would appreciate your review.
- If I fail to solve it within this timeframe, I will report back here so that more experienced developers can take over.
Thank you for your time and for maintaining this great tool!
Any PR must come from contributors who have signed the CLA. If you are interested, @beheh can help you. I believe the logic for secret exclusion is the same as HDT, so I wonder if the behavior also exists there.
Any PR must come from contributors who have signed the CLA. If you are interested, @beheh can help you. I believe the logic for secret exclusion is the same as HDT, so I wonder if the behavior also exists there.
Thank you so much for the clarification! I really appreciate your help. I’ll reach out to @beheh when I get a chance and discuss the CLA with him. Thanks again for pointing me in the right direction!