Fabric.Cashmere
Fabric.Cashmere copied to clipboard
(Opt-in) Fix navbar styles
Commit 39df6c3 introduced issues in sass/navbar.scss (https://github.com/HealthCatalyst/Fabric.Cashmere/blob/39df6c305bd2165761fddadb127b36a9f7aeb15c/projects/cashmere/src/lib/sass/navbar.scss).
- The
navbar-brand,navbar-app,navbar-item, andnavbar-linkmixins do not begin with thehc-prefix. - The
navbar-brandmixin makes assumptions about the consumer's HTML structure; namely, that any siblings of the same type will have the classnavbar-brand, that there will be a child element of classbrand, and that state will be tracked via ano-switcherclass. CSS properties are also not alphabetized. - The
navbar-appmixin makes assumptions as well, using element selectors where it should use unique classes with their own mixins. It also refers to alogo-condenseclass that doesn't have its own mixin. - The
navbar-linkandnavbar-itemmixins have their CSS properties out of order.