foundry-ui icon indicating copy to clipboard operation
foundry-ui copied to clipboard

Add color prop for checkbox icon

Open cnkeats opened this issue 4 years ago • 3 comments

fixes #372

cnkeats avatar Mar 31 '22 19:03 cnkeats

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6106e3486159df8dd1a5b52b4636eb2f0bd766f3:

Sandbox Source
React Configuration

codesandbox-ci[bot] avatar Mar 31 '22 19:03 codesandbox-ci[bot]

So, I know the AC in the ticket said "regardless of the variant and checkbox color" but I don't think that makes sense when actually trying it (see screenshot from codesandbox)

image

I would think the color prop would just change the general color of the checkbox (in this case where the green is), and we should be able to override the icon color separately

aVileBroker avatar Apr 08 '22 16:04 aVileBroker

Being able to control both would give us ultimate control

https://user-images.githubusercontent.com/7891559/162487773-bf5ba8f9-1543-4a5f-b1cd-518e0967de92.mp4

aVileBroker avatar Apr 08 '22 16:04 aVileBroker