He-Pin(kerr)

Results 344 comments of He-Pin(kerr)

> Some smallish things, I'm ok with the option from close but I think maybe @patriknw had a stronger opinion about aligning with the existing unfoldResource operator. I am ok...

I think `foldResource` `foldResourceAsync`'s `close` method sould be `R => Unit`, by returning `Option` here we can keep some flexibility. If you don't mind ,I will try to push this...

@johanandren CLA signed

close and reopen to trigger a new test.

Yes, I hope there will be a counterpart of `akka.dispatch.Futures` for `CompletionStage`, I could do some contribution if this ticket is triggered.

![image](https://user-images.githubusercontent.com/501740/169382264-9468614c-770e-4178-9526-f1bb2b32c652.png)

```scala @InternalApi private[akka] final class FoldResourceSourceAsync[T, S]( create: () => Future[S], writeData: (S, T) => Future[Option[Done]], close: (S) => Future[Done]) extends GraphStageWithMaterializedValue[SinkShape[T], Future[Done]] ``` @johanandren should the `writeData` returns a...

@tkawachi I have updated a new pr to follow up at :https://github.com/akka/akka/pull/31573

You are needing a warmup one?Sentinel from alibaba can do that ,you can take a look at it too

I more like the +T and -T syntax in Scala