hxcpp icon indicating copy to clipboard operation
hxcpp copied to clipboard

Don't define `_CRT_SECURE_NO_DEPRECATE` on non-windows targets.

Open MAJigsaw77 opened this issue 1 year ago • 3 comments

MAJigsaw77 avatar Oct 24 '24 07:10 MAJigsaw77

Here is a page from the microsoft docs which mentions the define, confirming that it's windows-specific: https://github.com/MicrosoftDocs/cpp-docs/blob/25815cbe0dd6bae018890dd85eb10e5e5feece8e/docs/c-runtime-library/security-features-in-the-crt.md

tobil4sk avatar Aug 02 '25 11:08 tobil4sk

I noticed, the msvc toolchain already adds this flag for all msvc builds: https://github.com/HaxeFoundation/hxcpp/blob/1618253d7bb2dd8eea1bc7ffcd612452df76a7b7/toolchain/msvc-toolchain.xml#L104

So I wonder if it's safe to remove it from haxe-target.xml?

tobil4sk avatar Sep 08 '25 07:09 tobil4sk

I noticed, the msvc toolchain already adds this flag for all msvc builds:

https://github.com/HaxeFoundation/hxcpp/blob/1618253d7bb2dd8eea1bc7ffcd612452df76a7b7/toolchain/msvc-toolchain.xml#L104

So I wonder if it's safe to remove it from haxe-target.xml?

Perhaps, if it doesnt break anything.

MAJigsaw77 avatar Sep 08 '25 07:09 MAJigsaw77