hscript icon indicating copy to clipboard operation
hscript copied to clipboard

Add string interpolation

Open DleanJeans opened this issue 7 years ago • 6 comments

For issue #61 This passes all the tests I wrote over DleanJeans/hscript-plus. Let me know if there's something wrong!

DleanJeans avatar May 04 '17 12:05 DleanJeans

Could you add some unit tests for it in Test.hx?

ncannasse avatar May 06 '17 08:05 ncannasse

I ran into a problem with string interpolation inside another ('${'string'}'). I'll need to modify Parser::readString() and it's gonna take a while. Would you mind helping me by explaining how string interpolation exactly works in Haxe itself?

DleanJeans avatar May 07 '17 14:05 DleanJeans

Do we really want this in hscript? String interpolation is an order of magnitude more complex than everything else, especially when it starts being nested. We haven't even solved that in the compiler properly.

Simn avatar May 07 '17 15:05 Simn

I guess I'll just leave it unsolved.

DleanJeans avatar May 07 '17 15:05 DleanJeans

Will this be merged any time soon? If not, at least I can leave it as a feature in my hscript-plus.

DleanJeans avatar May 08 '17 23:05 DleanJeans

Unless it's well tested and compliant with Haxe I think it shouldn't be merged.

ncannasse avatar May 10 '17 16:05 ncannasse