haxelib icon indicating copy to clipboard operation
haxelib copied to clipboard

"Set to version" prompt does not unset dev

Open jcward opened this issue 10 years ago • 3 comments

Just ensuring hxcpp is up to date, I got the:

You already have hxcpp version 3.2.193 installed.
Set hxcpp to version 3.2.193 [y/n/a]? y
Library hxcpp current version is now 3.2.193

But when I checked haxelib list, it was still set to dev. I find this confusing.

I'd think the above prompt should unset dev. Or, if you don't want to change the behavior of the tool, perhaps the note should read:

Library hxcpp current version is now 3.2.193, but dev override is /home/jward/...

Also, I'm not sure if the git override works the same way?

jcward avatar Dec 19 '15 15:12 jcward

Agree, the message could also specify the current version.

Similar issue https://github.com/HaxeFoundation/haxelib/issues/106

By git override do you mean haxelib git? If so it does make use of a dev set. (could change https://github.com/HaxeFoundation/haxelib/issues/263)

ibilon avatar Dec 19 '15 15:12 ibilon

Agree & try to explain..

  1. We don't need to remove .dev-file anyway in that use-case;
  2. Problem in the algorithm used in list command:
    • We have two files: .current & .dev;
    • Currently if .dev exists then .current will be ignored - it's wrong behaviour;
    • We need to prioritise .current over .dev.

boozook avatar Dec 22 '15 16:12 boozook

I think the original purpose of dev is to override any currently installed versions, so prioritizing .current over .dev does not make sense IMO and the current behaviour is actually correct.

What we could do is what @jcward originally proposed: either prompt to unset dev or mention that dev mode is in effect.

nadako avatar Dec 22 '15 16:12 nadako