[display] Remove legacy diagnostics

[kLabz]

:warning: Merge later

Should be merged sometime next year I suppose?

Closes #8086

[Simn]

Should we do this now?

[kLabz]

Well, hmm

• Latest vshaxe release still doesn't support Json RPC diagnostics (merged but not released)
• The number of people that have actually used Json RPC diagnostics is likely < 5 atm; we might want to release Haxe 5 preview with both, and then merge this

... which actually tells me there's potentially something missing before doing a vshaxe release: there's currently no way to opt out of Json RPC diagnostics, and in short term that might be annoying if it ends up being "broken" :thinking:

cc @AlexHaxe

[AlexHaxe]

I think we should put a useLegacyDiagnostics config option in vshaxe. and it probably should default to false so that people use new diagnostics in 4.3.5+ and 5, because nobody's gonna turn it on unless it's heavily advertised.

and then we should release a new vshaxe version soonish. I have two fixes for tokentree that should go in. there are a couple of issues with rename lib, but I haven't had the time to fix those. they can go into a later release when they are ready so it shouldn't be blocking a Json RPC enabled vshaxe release.

[kLabz]

Note that such a config option wouldn't work with Haxe 5 (and, more importantly, would make diagnostics fail if vshaxe tries to honor it on a Haxe version where this PR is merged)

[AlexHaxe]

true. we could use context.haxeServer.haxeVersion to limit it to supported versions (e.g. < 5.0.0) once this PR is merged. obviously that would leave nightlies without Json RPC with no diagnostics. but at least the stable release people will have an opt-out (not sure if there are people relying on nightlies for their projects).

[Simn]

This PR needs an update.

[kLabz]

It does indeed. Do we want to merge this for 5.0 preview, or later?

[Simn]

I see no reason to wait if there's no obvious problem with it.

[kLabz]

Well there's https://github.com/HaxeFoundation/haxe/pull/11740 but that's more an issue with multiple file diagnostics.

[kLabz]

Hmm, there's a bit of an issue here :sweat_smile:

Since display tests are now running for both xml and json rpc (since #11506), it's a bit of a mess to remove "xml" diagnostics without removing the rest of the xml display API :confused:

[Simn]

My understanding has been that we'll remove the entire XML API and that this would merely be a first step.

[kLabz]

Might be too much trouble to do it by steps because of this. I think there's still a couple of missing rpc endpoints, will check all that