haxe icon indicating copy to clipboard operation
haxe copied to clipboard

Pull requests for 4.3 Hotfix (part 4)

Open kLabz opened this issue 2 years ago • 1 comments

4.3.4

  • [ ] https://github.com/HaxeFoundation/haxe/commit/dd28b83951356dff776c451e8201fb64577679ac
  • [ ] 3a9445219a023253ff4c78cdbb84262e8f6a5276
  • [ ] 7653f686cdff23fa650c80eb4e87030a1b154687 / #11402
  • [ ] 13666860eceb09a98269d07d97ebbcc6abb6405f
  • [ ] https://github.com/HaxeFoundation/haxe/commit/ed838d789588487e817a326b60d31c4397ce9012
  • [ ] https://github.com/HaxeFoundation/haxe/commit/822dd87c1e7e56caac29aa3d42eb7879edeebade
  • [ ] https://github.com/HaxeFoundation/haxe/commit/dbc9952adf5a7ab30c430ddca0428313dbb1e376
  • [ ] https://github.com/HaxeFoundation/haxe/issues/11560

See also:

  • https://github.com/HaxeFoundation/haxe/milestone/23
  • https://github.com/HaxeFoundation/haxe/issues/11526 (check against 4.3.3)

kLabz avatar Nov 19 '23 13:11 kLabz

Not sure if possible to merge, but compilation server improvements will be nice to have for stable releases before 5.0 https://github.com/HaxeFoundation/haxe/commit/486dfc80866173a2d57c47476e5e4590c30e3504

RblSb avatar Nov 21 '23 17:11 RblSb

Not sure if possible to merge, but compilation server improvements will be nice to have for stable releases before 5.0 486dfc8

I didn't include this, as it's kind of a big change (and big merge conflicts) for a patch release :/

kLabz avatar Feb 18 '24 16:02 kLabz

Could the next 4.3 release include Apple Silicon binaries as well? #11572

tobil4sk avatar Feb 27 '24 21:02 tobil4sk

I will try, iirc there were issues last time.

Btw, I've seen people complain about the installer not being "universal", do you think it would be easy to update?

kLabz avatar Feb 28 '24 06:02 kLabz

Btw, I've seen people complain about the installer not being "universal", do you think it would be easy to update?

I guess we'd need Neko universal binaries too.

tobil4sk avatar Feb 28 '24 08:02 tobil4sk

This will have to wait for 4.3.5

kLabz avatar Mar 04 '24 09:03 kLabz

https://github.com/HaxeFoundation/haxe/issues/11177 is broken in release UPD: this is https://github.com/HaxeFoundation/haxe/commit/486dfc80866173a2d57c47476e5e4590c30e3504, nevermind

RblSb avatar Apr 21 '24 14:04 RblSb

Null coalescing logic has not been updated in release branch:

@:using(Main.MoneyTools)
typedef Money = Int;

class MoneyTools {
	public static function inflate(money:Money):Money {
		return money + 99;
	}
}

class Main {
	static final money:Null<Money> = 1; // ok without Null<...>

	static function main() {
		final money = money ?? return;
		$type(money); // Int
		money.inflate(); // Missing fields for this
	}
}

RblSb avatar May 16 '24 15:05 RblSb

What issue/PR are you talking about here?

kLabz avatar May 16 '24 15:05 kLabz

I think this is about commits from https://github.com/HaxeFoundation/haxe/issues/11425

RblSb avatar May 16 '24 15:05 RblSb