haxe icon indicating copy to clipboard operation
haxe copied to clipboard

Restoring lua tests

Open tobil4sk opened this issue 3 years ago • 0 comments

Seems like we forgot to fix the lua tests after "temporarily disabling them" in 8027d746888afb9aeeee077b737dec175417945a

We discussed this on slack a long time ago, but we need to update: https://github.com/jdonaldson/haxe-deps as the git: protocol is no longer supported (which is used in the source url). I think it can just be updated to https.

@jdonaldson I made a PR for this, would you be able to handle making a release? https://github.com/jdonaldson/haxe-deps/pull/2

Also, it is worth considering adding luasec to the file, because it is now a potential dependency since: #10593. This haxe-deps project seems to be used to install all potential dependencies, even if they are not necessarily used in all haxe lua projects, so it makes sense to add it. Right now we have to install it manually for the tests: https://github.com/HaxeFoundation/haxe/blob/55f4b332022e6e84503db0f6bfa251112dcc8127/tests/runci/targets/Lua.hx#L73-L74

We should also probably mention haxe-deps in the manual, but that is an issue for that repository.

tobil4sk avatar Aug 19 '22 15:08 tobil4sk