flixel
flixel copied to clipboard
HaxeFlixel
Fixed the lag issue
Don't merge it yet untill https://github.com/openfl/openfl/pull/2577 is merged
the reason i say this is because when that is pull request is merged then you can merge this one too
This doesn't seem like a "lag" issue. It sounds like performance will be improved by the openfl PR, regardless of this flixel PR. Intead, setting version 120 will prevent shaders from breaking entirely on certain targets.
That seems fine, but I just want to make sure we know what we're fixing, and whether this fixes that.
@MasterEric can you shed some light on this PR? Am I correct?
I had a conversation with Jonny earlier. This PR somewhat confuses me since glVersion acts like the other metadata in that it is INHERITED.
He says he gets improved performance on Mac with this change but the glVersion should be 120 already (since the parent class sets it to 120).
Having the glVersion = 120 should do what you described in terms of compatibility though.
Thanks Eric
@ItsyourboyJonnycat sounds like this PR doesn't do anything, if you can prove that this line does anything (maybe by looking at the resulting cpp build) then glVersion must not be inherited, like previously thought. if that is true, we can either reopen this PR or figure out why FlxGraphicShader isn't inheriting the gl version of the parent class