Adding pitch support

[Cheemsandfriends]

I know there's already a PR that's been merged in lime right here but that build doesn't seem to be public yet, sooo I decided to make this support as local as possible (also that it may work on more than one version while using lime idk)

[Cheemsandfriends]

I'll work on this, it's just that it works when you play and change the pitch, but when you play it with the pitch already given, it doesn't for some reason?

[Cheemsandfriends]

I think the failing on cpp is a false alarm, cos I have everything ok (testing on desktop at least), and if I check on the cpp builds, there seem to have an error somewhere in Run HaxeFlixel/setup-flixel@master which honestly I can't find the error.

[Cheemsandfriends]

I also addressed the concerns that you have about the code I made, when you can tell me if you have any questions about what I replied or adding some suggestion of my code

[Geokureli]

I think the failing on cpp is a false alarm, cos I have everything ok (testing on desktop at least), and if I check on the cpp builds, there seem to have an error somewhere in Run HaxeFlixel/setup-flixel@master which honestly I can't find the error.

I don't think it's a false alarm, I'm seeing the unit tests failing at:

Class: flixel.system.FlxSoundGroupTest .
Segmentation fault (core dumped)

Have you ran the unit tests on cpp? Have you tried using this feature for sounds in a soundGroup? try using this feature with FlxG.sound.play(...), it will add the sound to the default sound group

[Cheemsandfriends]

I hope you don't mind re-re-requesting another review about this @Geokureli lmao

[Geokureli]

also do you have a little tiny project that uses this feature you could share?

[Cheemsandfriends]

also do you have a little tiny project that uses this feature you could share?

I have one little project that I used for testing back in the lime pr. do you want me to publish that thing?

[Geokureli]

do you want me to publish that thing?

Either that, or send me a relevant snippet, or zip it on discord

[Cheemsandfriends]

Either that, or send me a relevant snippet, or zip it on discord

Sure! here it is!

[Cheemsandfriends]

and I believe this should wrap it up @Geokureli?

[Geokureli]

something is odd about this, I feel I was wrong about the order here. FLX_NO_PITCH needs to be set to true on flash and openfl legacy before defineInversions is called.

Right now it's still failing on flash

[Cheemsandfriends]

something is odd about this, I feel I was wrong about the order here. FLX_NO_PITCH needs to be set to true on flash and openfl legacy before defineInversions is called.

Right now it's still failing on flash

I believe it was still failing on flash cos I forgot a semicolon when setting the FLX_NO_PITCH thing. let's wait for the checker to check everything, but even then, I do believe that my setting of stuff wasn't bad but whatev lmao

[Geokureli]

oh no, it was failing on flash because I was testing with your demo, which should fail on flash, Im dumb

[Cheemsandfriends]

oh no, it was failing on flash because I was testing with your demo, which should fail on flash, Im dumb

Oh LMAO

[Cheemsandfriends]

a/w I think that rn it's somewhat acceptable to merge, unless there's another change that should be made @Geokureli?

[ninjamuffin99]

I think it would be nice / accessible to have a demo, or at the very least a snippet that nicely demos the new pitch support, just suggestion tho !!!

[Cheemsandfriends]

I think it would be nice / accessible to have a demo, or at the very least a snippet that nicely demos the new pitch support, just suggestion tho !!!

I don't mind if geokureli wants to use this as a pitch sample. I doubt it but if he wants to I won't mind lmao

[Geokureli]

thanks cheems, I'll probably use that as a starting point, if not, as is