Fix for incorrect handling of `CLICK_EVENT` in FlxUIPopup

Open UncertainProd opened this issue 2 years ago • 4 comments

It looks like FlxUIPopup was expecting one of the event paramters in getEvent to be either "affirm", "cancel" or "alt" but that never happens (even the default_popup.xml file never mentions "affirm", "cancel" or "alt" https://github.com/HaxeFlixel/flixel-ui/blob/dev/assets/xml/default_popup.xml ). This should remove references to that and only uses the buttonAmount parameter when handling click events for FlxUIPopup. This should also fix HaxeFlixel/flixel-demos#267

Nov 28 '23 21:11 UncertainProd

Can you do me a favor and merge the dev branch back into your branch. I made changes to the github actions

Nov 29 '23 00:11 Geokureli

Done

Nov 29 '23 16:11 UncertainProd

I'm trying out the demo locally, without this change, and I can't reproduce any specific error on html5 with any of the popups. What are the steps to reproduce?

Dec 04 '23 15:12 Geokureli

In the RPG Interface demo, if you click Default asset test -> Popup then you will be stuck on the popup screen and will be unable to get back to the main menu (basically https://github.com/HaxeFlixel/flixel-demos/issues/267 )

Dec 05 '23 16:12 UncertainProd