Tdarr icon indicating copy to clipboard operation
Tdarr copied to clipboard

Flow "Review" vs Plugin Stack "Accept" behavior with "Auto accept successful transcodes"

Open coyodi opened this issue 1 year ago • 2 comments

Is your feature request related to a problem? Please describe. Sometimes when adding new content/libraries I prefer to review transcodes before overwriting the old file, sometimes not. However, since I use a Flow for my Library Transcoding Decisions, I've noticed that the "Auto accept successful transcodes" option under Staging Section does not apply to Flows with a Require Review node. This option functions correctly while using a Plugin Stack.

Describe the solution you'd like Ideally, I'd like for that checkbox to also respect the "Require Review" node. Auto-Accepting/Reviewing and adding content to the library when it is checked, and awaiting my Review/Acceptance when not checked.

Describe alternatives you've considered Currently, I have to update my Flow each time I want to change this behavior which is not ideal. Even if a new node for "Request Accept" was added to the Flow menu, that'd be perfectly workable for my needs. :)

Thank you for the support!

coyodi avatar Apr 06 '24 12:04 coyodi

Just experienced this and came here to post a potential bug. Totally agree with the OP.

grahamcropley avatar Apr 29 '24 21:04 grahamcropley

I guess wasn't sure whether to apply this behaviour but yes makes sense in that case. I've updated it for next version. Also added a pop-up with this info:

Auto accept successful transcodes:


Enabling this option will auto-accept successful transcodes waiting in the staging section.

If using Flows, it will auto accept items which have staging status "Review required" caused by the "Require Review" flow plugin.

HaveAGitGat avatar May 06 '24 06:05 HaveAGitGat

2.18.01 released

HaveAGitGat avatar May 14 '24 07:05 HaveAGitGat

2.18.01 released

Not sure if this is adjustable to turn on or off, the way I had my flows set up I had a few files endlessly loop for a few hours before I caught it. I need to adjust my flow set ups with this new feature defaulted on.

nichols89ben avatar May 15 '24 16:05 nichols89ben