ImplicitCAD icon indicating copy to clipboard operation
ImplicitCAD copied to clipboard

Main module missing haddock

Open isovector opened this issue 3 years ago • 4 comments

As a newcomer to CAD (but not to Haskell), the haddock pages leave much to be desired. For example, what is this R parameter to all of the write functions? It's completely undocumented. Diving into the source suggests it's some sort of resolution, but I'm unsure if I should be giving it big or small values. A good rule of thumb is that every function and non-obvious parameter exported by the main module should have haddock.

isovector avatar Nov 05 '20 20:11 isovector

Here are some things I've learned in playing around with the system.

  1. Smaller resolution values result in clearer models (and superlinear slow downs when rendering)
  2. The camera for PNG3 appears to be facing forwards
  3. The coordinate system is (width, depth, height)
  4. Functions that end in R have a "roundness" as their first parameter. It's unclear what units this is measured in.
  5. Size and position units appear to be in mm

isovector avatar Nov 08 '20 03:11 isovector

Could you submit those as changes to the comments? the state of the haddock docs is sad, my apologies.

julialongtin avatar Nov 12 '20 20:11 julialongtin

Gladly. I'll try to get that done this weekend.

isovector avatar Nov 12 '20 21:11 isovector

I believe you've fixed this. ;)

julialongtin avatar Nov 15 '20 11:11 julialongtin