GWToolboxpp icon indicating copy to clipboard operation
GWToolboxpp copied to clipboard

Draw all quests (minimap, symbol renderer) problems:

Open henderkes opened this issue 1 year ago • 6 comments

ticking it makes no quest markers drawn at all image

even if it's unticked, quests are cycled through, but don't cycle back, so the active quest changes every time you zone.

henderkes avatar Apr 13 '24 18:04 henderkes

Check how this behaves with this setting too image

3vcloud avatar Apr 13 '24 18:04 3vcloud

Edit: drawing of multiple markers does actually seem to work. Just wasn't getting one on any of the 4 quests there, for some reason,

henderkes avatar Apr 13 '24 18:04 henderkes

image when this setting is on, the active gw quest marker should be skipped, otherwise you get a double draw on it also check that we don't draw the same position multiple times - so if a position is drawn ingame, we shouldn't draw any markers on that same position in toolbox image

edit: we should also make a setting that gives a different colour to the actually active one, otherwise without the in game quest marker you'll be very lost

henderkes avatar Apr 13 '24 18:04 henderkes

even if it's unticked, quests are cycled through, but don't cycle back, so the active quest changes every time you zone.

I couldn't reproduce this. Checking the commit history, I removed the cycling active quests workaround in December so it isn't this feature causing it. I therefore also couldn't check the interaction with the "keep current quest" game option.

For the improvements and maybe moving the setting, I'll leave that up to you two and your judgement.

adituv avatar Apr 13 '24 21:04 adituv

I think we should shelve this feature, its just very useful in practice and has a lot of edge cases

3vcloud avatar Apr 13 '24 22:04 3vcloud

I don't think we should. It's really cool and useful when done right, so unless it's technical difficulties preventing it, I'll have a look into it when I get more free time. Can leave it as it is for now, except that we have to figure out what causes the quest switching.

henderkes avatar Apr 13 '24 23:04 henderkes