Harvie
Update dial_read.ino
I wanted to catch the final number in a variable finalNumber, so that this can be sent to for example the tx port. So I added two lines in the setup: String num = ""; and String finalNumber = ""; And made a change in the beginning of the loop.
I see. Perhaps you can add another example file. eg. dial_read_string.ino rather than modifying the original example? So we have two examples. one simple and one advanced. For users to choose from.
Sure I can do that. Does this mean that you like my solution? Jaap Klevering
On 18 Mar 2022, at 14.10, Tomas Mudrunka @.***> wrote:
I see. Perhaps you can add another example file. eg. dial_read_string.ino rather than modifying he original example? So we have two examples. one simple and one advanced. For users to choose from.
— Reply to this email directly, view it on GitHub https://github.com/Harvie/RotaryDial/pull/3#issuecomment-1072351088, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYA4WICTGMJN4PFRIJT3PDVARXEDANCNFSM5RBUY4JA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.
To be honest i am not a big fan of using C++ strings in embedded applications. However i am only concerned about efficiency of library itself and i do not really care what people do with data received from library. If such use makes sense to you more than the original, i think that we might have multiple examples, so everyone can choose what they prefer.
Adding features to library itself would be a different story. I would require such code to be optimized and minimalistic. For examples i don't care too much.
That’s what i thought. Your code is very clean and minimalistic. I appreciate that very much. One day perhaps I’ll know something more about C++ and do just that!
I created a new file with the name: dial_read_string.ino It is located in my branch inside the second patch. Not sure what to do next, or can I just leave it there?
Jaap
On 18 Mar 2022, at 14.21, Tomas Mudrunka @.***> wrote:
To be honest i am not a big fan of using C++ strings in embedded applications. However i am only concerned about efficiency of library itself and i do not really care what people do with data received from library. If such use makes sense to you more than the original, i think that we might have multiple examples, so everyone can choose what they prefer.
Adding features to library itself would be a different story. I would require such code to be optimized and minimalistic. For examples i don't care too much.
— Reply to this email directly, view it on GitHub https://github.com/Harvie/RotaryDial/pull/3#issuecomment-1072359012, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYA4WLYT6A25SZ2GBRLFPLVARYLRANCNFSM5RBUY4JA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.
Not sure what to do next, or can I just leave it there?
You did your changes in different branch than is refferenced by this pull request. you need to either change this pull request to use your newly created "patch-2" branch. (or put the changes into original "patch-1" branch, but the former is probably easier).
Also i beleive the dial_read_string.ino should go in new directory called dial_read_string, not in the dial_read directory.
Yep, inside the branch 1, i created a new folder (under examples) and there it is! Wow. I call it a day. Thank you for all your help! I learned something…. Jaap
On 18 Mar 2022, at 14.41, Tomas Mudrunka @.***> wrote:
dial_read_string
Yes, but you still left modified dial_read.ino in place.
You can see here: https://github.com/Harvie/RotaryDial/pull/3/files
confusing…..
On 18 Mar 2022, at 20.05, Tomas Mudrunka @.***> wrote:
Well now there is only the new example, but not the old one :-)
— Reply to this email directly, view it on GitHub https://github.com/Harvie/RotaryDial/pull/3#issuecomment-1072663365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYA4WKXWYES6SACURZBSLTVATAYDANCNFSM5RBUY4JA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.