Grasscutter

Grasscutter copied to clipboard

Implement new drop system. Full chest drop support (by @eternalcomet )

1

see https://github.com/Grasscutters/Grasscutter/pull/1951

Hartie95

Fix and refactor (dungeon) challenges and use the DungeonChallengeConfigData to get the challenge type (can be annoying because of variable arguments)

2

Currently there are many challanges that don't work as expected, for example they finish after one instead of many monsters killed. The params of calls to `ScriptLib.ActiveChallenge` are different depending...

Hartie95

Besidest the generall rework of how accepting quests is handle, we also need we need working quest conditions to implement propper automatic quest progression. The work for each condition differs...

Hartie95

To be able to propperly complete and fail quests we need to implement the missing Quest content triggers. The work for each trigger differs a bit, some are easier, while...

Hartie95

## Description Please carefully read the [Contributing note](https://github.com/Grasscutters/Grasscutter/blob/stable/CONTRIBUTING.md) and [Code of conduct](https://github.com/Grasscutters/Grasscutter/blob/development/CODE_OF_CONDUCT.md) before making any pull requests. And, **Do not make a pull request to merge into stable unless it...

mjolsic

Updated with how talks are handle

1

### Updates: 1) Use TalkExcelConfigData.json instead of talk data in mainQuestData 2) Added execute triggers when finishing talks. The old method will cause problem since execute triggers can come from...

mjolsic

Show add avatar notify

1

## Description Show fullscreen avatar add notify, to config.json after "questing" add "isShowAvatarAddNotify": true (by default it false) to enable it ## Type of changes - [ ] Bug fix...

BiosNod

[Feature Request] 关于3.3

18

我利用GC3.3版本的核心 并利用xuzhong.dong的泄露 结合了res对应任务的Lua脚本 事实上原本GC添加任务后结束任务需要手动添加下一个任务 然而Lua脚本自动添加了下一个任务 大任务与子任务等之间的衔接已经没有了问题 但是任务中关于走到某个地方附近时 Lua脚本报错   这似乎是来自\src\main\java\emu\grasscutter\scripts\data\ScriptArgs.java Lua脚本需要userdata而核心规定的这个脚本为int 听说这个仓库修复了剧情 但他停留在了3.1 于是我将3.3的proto替换在了此分支 可依然4206 希望作者能够尝试更新3.3（？）

Adelaide114514

### Know Issues: - Scene weather is only workaround fix, area like Lupi Boreas and DragonSpine don't have weather set yet - Weather doesn't show in subscenes. - Dungeon exit...

mjolsic

### Fixed issues: - Double play of cutscenes now fixed, trying to make it send packet as close to the officials as possible - Removed CONTENT_FINISH_PLOT from Quest finish(), seems...

mjolsic