Grasscutter icon indicating copy to clipboard operation
Grasscutter copied to clipboard

Small Ability Fixes

Open scooterboo opened this issue 5 months ago • 2 comments

Description

GameConstants.java -> "Avatar_Trampoline_Jump_Controller" is needed to make bouncy mushrooms work. Added other things in the same area. Let me know if that is unwise.

AbilityModifier.java -> Added luaCallType and funcName so I can use those in ActionServerLuaCall. Changed params to DynamicFloat.

AbilityManager.java -> Handled a nurupo that protoString was making. Added modChange printing for flavor.

ActionExecuteGadgetLua.java -> When it can't owner, make it target instead. More research is gonna happen tomorrow.

ActionServerLuaCall.java -> calls lua functions from the ability bin data. There's a few more besides "FromGroup", but FromGroup is the easiest and most common.

GroupEventLuaContext.java -> context.target_entity_id and context.source_entity_id happens from time to time. This makes that not die horribly.

BaseHandler.java -> This actually shows you which specific function in ScriptLib needs implementation instead of just saying "ScriptLib!"

GameSession.java -> BANNED_PACKETS was changed to be strings instead of numbers. If nothing else, we need this patched in ASAP so that the one person who still plays this branch doesn't get WindSeedClientNotify'd.

  • [x] Bug fix
  • [x] New feature
  • [x] Enhancement
  • [ ] Documentation

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] My pull request is unique and no other pull requests have been opened for these changes
  • [x] I have read the Contributing note and Code of conduct
  • [x] I am responsible for any copyright issues with my code if it occurs in the future.

scooterboo avatar Sep 25 '24 01:09 scooterboo