git-graph
git-graph copied to clipboard
HarshKapadia2
refactor: modify top nav
Please add some padding.
The OG page looks off.
Even this.
Also, even if you do, I think you should go back to the previous one.
This reduces the viewing area. Doesn't look the best.
There is a fix to this, though.
You show the top nav when the user scrolls up. And when we are scrolling normally, hide it.
Good ideas, thank you @tusharnankani!
Added padding.
Implemented a hacky solution for hiding the header. I will have to change it later. I'm quite tired after not being able to figure out a proper way for quite some time.
Can you explain what is hacky in this PR? I can't seem to understand what is.
Well, it should be a scroll event and not a wheel event. Also, the current wheel implementation in the project is a little buggy. It's just hacky overall - getting the desired effect through an unsuited implementation.