DVD-GAN icon indicating copy to clipboard operation
DVD-GAN copied to clipboard

Reason to use tanh instead of ReLU in ConvGRUCell?

Open cvcore opened this issue 5 years ago • 4 comments

Hi @Harrypotterrrr ,

thanks for the nice implementation. I was wondering if there is a specific reason for you to choose tanh instead of ReLU for the activation of out_gate, as in the paper https://arxiv.org/pdf/1907.06571v2.pdf?

To be specific, it's this line I'm referring to: https://github.com/Harrypotterrrr/DVD-GAN/blob/d8c4b6a4adb6217eb959eed0ea041a67589869cf/Module/ConvGRU.py#L51

cvcore avatar Oct 01 '20 14:10 cvcore

Hi, I haven't done this work for a long time since the result is not plausible, which I think is caused by limited computing resources, comparing Nvidia used 100 x V100 to train the DVD-GAN. Even so, I think there are still some bugs and omissions of this implementation. Anyway, thanks for your pushing this issue. Could you please try this out and find if the result improves? Moreover, I think you could try to contact @vominhduc for more information? @vominhduc Do you have any progress on this implementation? :confounded:

Harrypotterrrr avatar Oct 02 '20 14:10 Harrypotterrrr

Hi @cvcore @Harrypotterrrr , I have tried to improve the code to some extent but the results are not improved much. Currently, we can observe the shape of the people but the quality is too bad. I am still looking for a better PC to train the code. Btw, I will keep you updated if any progress.

vominhduc avatar Oct 04 '20 06:10 vominhduc

@vominhduc Thanks for your effort sincerely.

Harrypotterrrr avatar Oct 04 '20 07:10 Harrypotterrrr

Thanks for the reply @Harrypotterrrr @vominhduc ! I look forward to your further update.

cvcore avatar Oct 04 '20 18:10 cvcore