overlay
overlay copied to clipboard
Champion picks are not displayed in ARAM
Champions assigned in ARAM are not displayed in webapp. This is most likely related to the fact that we set champion picks through Actions
and not through PlayerSelections
.
The simplest hack would be to set the new champion twice in webapp: one when Action
is completed and one when PlayerSelection
gets updated. This also matches the way the client works: the championId
fields both in actions
and myTeam/theirTeam
change in one update.
The drawback is that we'd have to send the update to webapp twice, which is less optimized.
The other possible fix would be to track PlayerSelection
updates only when actions
is empty or does not contain any pick action. actions
is only empty when there are no actions getting performed in the draft (be it pick
, vote
(for one for all IIRC), ban
or ten_bans_reveal
), which is our case in ARAM (unless Riot wants to put bans back into ARAM in which case we can handle it by checking if we have pick actions).
That way, we only have to send one update to webapp and not even have to handle actions updates.