Harishankar.1
Harishankar.1
> What do you mean by "never identified"? No warning for unnecessary parenthesis? @powerboat9 I guess the "identification" he meant is nothing but a creating a specific node in the...
I kind of digged down a bit, and found that the Parser (AST): Actually does identify them, but the Lowering (HIR): Does not identify them (it throws them away).I think...
@powerboat9 Thanks for the feedback! I dont really know how did i miss this.. I've updated the fix to properly handle never-type coercion. Instead of rejecting continue as a value,...
@powerboat9, @philberty
@philberty LMK, if any changes required. Applied all the ones which you pointed out. :)
> https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=f4db2628116a78ca94e09a3cf1bcfb21 > > Having a predicate of type `!` should work -- it gets coerced into a boolean. See https://doc.rust-lang.org/reference/types/never.html, though don't get confused by the last paragraph @powerboat9...
> nearly there Yeah completed as per your suggestions,waiting for your review @philberty
> you need to fix the commit format CI is failing for you. Yep, done @philberty
> OK I think this is ready but before we merge can you show an example of -fdump-tree-gimple in the git commit message of what we are doing here for...