MirageRender

MirageRender copied to clipboard

Catch exceptions in main()?

1

I expect that exception handling is usually supported by a C++ program. I wonder why your function "[main](https://github.com/Harha/MirageRender/blob/55024ea404d664a0e2720d536b898ab831496793/src/main.cpp#L29)" does not contain [corresponding try and catch instructions](https://stackoverflow.com/questions/368184/does-it-make-sense-to-catch-exceptions-in-the-main) so far. How do...

elfring

Remove unnecessary null pointer checks

2

[An extra null pointer check is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null) like in [the macros "`DELETE`" and "`DELETEA`"](https://github.com/Harha/MirageRender/blob/2d6a0955aced291cbdab42594a5da6c9ea2dfd3e/src/macros.h#L14).

elfring

Improve exception safety with smart pointers

1

Would you like to wrap any pointer data members with the template class "[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr)"? Update candidates: - [Material](https://github.com/Harha/MirageRender/blob/55024ea404d664a0e2720d536b898ab831496793/src/core/material.cpp#L27) - [Scene](https://github.com/Harha/MirageRender/blob/55024ea404d664a0e2720d536b898ab831496793/src/core/scene.cpp#L21)

elfring