Harel M
Harel M
The results can be several output types: osm, geojson, csv. I find it difficult to really wrap this in something genetic enough on one hand and strongly typed on the...
I think this class is a good starting point :-) I think that creating a request query and executing it can be two separate responsibilities. Note, as can be seen...
I'll review the PR in the next few days, hopefully, and if everything is approved we'll need to release a new version.
Visual studio for mac is just the worst. If you can, try using rider from jet brains. It's free for open source developers.
I'm not even sure it should parse the results as there can be few response formats (csv, json, osm, others?).
That's actually a valid option as the client won't do much beside slightly wrap httpclient.
No argue here. But the client shouldn't only support one format, it should at least support osm, json and csv (I'm not familiar with others). It might be 3 different...
Unit test to try and create as many scenarios as possible to make sure that adding nodes, ways, attributes, etc. generates the right query string I believe.
No, there's no need for a client to make sure the tests are working as expected. You might want to make sure the query is working and correct using either...
So we can close the current PR that you opened? Is it still relevant?