Harel M

Results 2711 comments of Harel M

The failing unit tests are related to marker's opacity changes when behind the terrain. It is probably related to some of the method name changes, and the fact that mocking...

I've merged the following PR to main and afterward to the globe branch: - #3136 I think this is what created the last conflict. We'll need to think how to...

According to latest coverage report (which might have bugs unfortunately, so you might need to verify this locally) the following files are missing some coverage: the utils classes should be...

Thanks, there are a few last comments that I need to check on my side, I'll report back once I do. Overall, I think this is mostly ready, I'll do...

I think my review is mostly done. Thanks @kubapelc for you patience and changes, and for putting up with my annoying review comments. There are still a few open review...

I'll hold up with this PR as the globe is doing some radical changes in transform class. If you could redo this PR against the globe branch it would be...

@chrneumann transform class has changed dramatically. I'll close this PR for now, if you feel this is needed please open a new PR against the new code. Thanks for taking...

I also think the examples should use es6 style import instead of using the global maplibre object, not just the readme. I don't think it's a big effort and will...

Since maplibre is packaged using commonjs, using it with a module type script is not possible ATM 😕

Is there a repo that needs to be maintained under the maplibre org as part of this onboarding request? If so, please update the post above.