Harel M

Results 2711 comments of Harel M

Since I don't have a better idea what parameters can be add to the sky let's continue with this design proposal, these parameters make sense to me as opposed to...

I'll push forward the linked PR. I'll also add some experimental warnings ATM and also won't add any supported version. If this won't be implemented we will remove it from...

There's is an implementation that got a bit stale here, I hope to push it forward after this issue is properly defined: https://github.com/maplibre/maplibre-gl-js/pull/1713 The parameters described in Cesium are very...

I've created the above linked PR: #478, feel free to review it. Once reviewed I'll merge it and release a new version of the style-spec package to allow continuing to...

I believe when looking at the map in 2D you don't want it "as realistic" as 3D. A design consideration I believe, not sure though. @prozessor13 do you remember why?

I'm not sure this is finalized as there is a comment, which I'm not sure is well defined regarding the spec about a secondary color to the sky, see here:...

Written by @prozessor13 here: - https://github.com/maplibre/maplibre-gl-js/pull/3645 It should be easy to implement a second sky color to create a 2-color gradient, and i think i can find time for this...

I think the names are good, the only thing that is not intuitive is the fog-blend - blend between fog and what? Others are describe and make sense to me,...

@pheonor what do you think since you are looking into atmosphere effects now? I thought that "ground" might be the relevant word here: `ground-atmosphere-blend` or `fog-ground-blend`. It's true that currently...

I believe we can have a section inside the sky for atmosphere, or do you think it should be a different section altogether? I find the sky and atmosphere to...