ore-cli icon indicating copy to clipboard operation
ore-cli copied to clipboard

Use tokio tasks

Open Milo123459 opened this issue 1 year ago • 3 comments

Uses tokio tasks instead of std::thread::spawn

Milo123459 avatar Aug 08 '24 13:08 Milo123459

gives a ~1.5% improvements on a server with 16 cores / 32 threads

zakajd avatar Aug 08 '24 14:08 zakajd

Reviewing now. How many samples did you take to measure 1.5% improvement? There's a lot of noise in the benchmark as it can vary a lot from one run to the next

HardhatChad avatar Aug 11 '24 14:08 HardhatChad

Well, this will just improve scheduling. Thanks to the parallel starting of the tasks, it will be a little bit faster. I can update this PR if you'd like to fix conflicts?

Milo123459 avatar Aug 11 '24 18:08 Milo123459