hal-cgp icon indicating copy to clipboard operation
hal-cgp copied to clipboard

Remove `n_rows` and `levels_back` parameters

Open HenrikMettler opened this issue 3 years ago • 2 comments

For historical reasons, our genome has parametersn_rows, levels_back. However they offer little benefit in optimization and in actual applications these are never used. To simplify things and improve the user experience we should remove these parameters.

HenrikMettler avatar Jan 20 '22 13:01 HenrikMettler

One question that arises, is whether we should also stop using the name n_columns and simply name it n_hidden since these things would become equal

HenrikMettler avatar Jan 20 '22 14:01 HenrikMettler

yes, i think that would be a good idea. n_columns may be difficult to understand without the option of adding rows :D

jakobj avatar Jan 21 '22 16:01 jakobj