hal-cgp icon indicating copy to clipboard operation
hal-cgp copied to clipboard

Compare set expression for output to target expression

Open HenrikMettler opened this issue 4 years ago • 4 comments

When using genome.set_expression_for_output one usually has a target expression that the output node should compile to. Since mistakes in setting the dna can happen easily (eg. by changing the order of primitives) - a built-in check can be useful. This PR implements the comparison using sympy.parse_expr and a compilation to sympy of the genome.

HenrikMettler avatar Jan 13 '22 09:01 HenrikMettler

ping @HenrikMettler

jakobj avatar Feb 14 '22 10:02 jakobj

Did @HenrikMettler resolve all your comments, @jakobj ? Could you give this another check?

mschmidt87 avatar Oct 13 '22 12:10 mschmidt87

i think i don't have any more pressing comments, besides squashing commits please and fixing tests :)

jakobj avatar Oct 24 '22 12:10 jakobj

@HenrikMettler could you fix the tests, rebase on master and squash the commits?

mschmidt87 avatar Dec 14 '22 00:12 mschmidt87