vbot icon indicating copy to clipboard operation
vbot copied to clipboard

MessageExtension 疑似逻辑错误

Open dchaofei opened this issue 6 years ago • 2 comments

原代码

    private function addServiceExtension($extension)
    {
        if ($extension instanceof AbstractMessageHandler) {
            throw new ExtensionException($extension.' is not extend AbstractMessageHandler');
        }

        $this->serviceExtensions[] = $extension;
    }

if 里应该添加个吧,但是代码没有报错,不敢确定,没敢提 pr

修改后

    private function addServiceExtension($extension)
    {
        if (!$extension instanceof AbstractMessageHandler) {
            throw new ExtensionException($extension.' is not extend AbstractMessageHandler');
        }

        $this->serviceExtensions[] = $extension;
    }

dchaofei avatar Aug 02 '18 03:08 dchaofei

看起来确实是这样,但是实际修改后反而就抛异常了

pgyf avatar Sep 12 '18 10:09 pgyf

那就很奇怪了。。。

dchaofei avatar Sep 14 '18 06:09 dchaofei