foundation-sdk icon indicating copy to clipboard operation
foundation-sdk copied to clipboard

getHandler 的一点疑问

Open limingxinleo opened this issue 3 years ago • 1 comments

Http 那里,我感觉有点问题

以下这个方法,如果存在 $default['handler'] 的话,感觉不应该当成一个 middleware push 进来,而是直接使用 setHandler 吧

    protected function getHandler()
    {
        $stack = HandlerStack::create();

        foreach ($this->middlewares as $middleware) {
            $stack->push($middleware);
        }

        if (isset(static::$defaults['handler']) && is_callable(static::$defaults['handler'])) {
            $stack->push(static::$defaults['handler'], self::USER_DEFINED_HANDLER);
        }

        if (isset($this->app['guzzle_handler'])) {
            $guzzleHandler = $this->app['guzzle_handler'];
            $stack->setHandler(is_string($guzzleHandler) ? new $guzzleHandler() : $this->app['guzzle_handler']);
        }

        return $stack;
    }

limingxinleo avatar Jul 24 '20 10:07 limingxinleo

我在使用中也遇到了这问题 我现在打算和你一样去掉 if ($this->stack) { return $this->stack; }

tb07 avatar Sep 08 '23 03:09 tb07