Laravel-Pagebuilder icon indicating copy to clipboard operation
Laravel-Pagebuilder copied to clipboard

Ability not to install DB configs

Open ange007 opened this issue 3 years ago • 3 comments

Auto merge config from config/database.

Can use for DB in config/pagebuilder only:

    'storage' => [
        'use_database' => false,
        'database' => [
            'driver'    => 'mysql',
            'prefix'    => 'pagebuilder__',
        ],
        'uploads_folder' => storage_path('app/PageBuilder/uploads')
    ],

ange007 avatar Dec 30 '20 12:12 ange007

What was exactly the issue that is fixed by this PR?

HansSchouten avatar Dec 30 '20 18:12 HansSchouten

The problem of the need to duplicate the database parameters in the pagebuilder's config. At the moment I am only setting up the library - but this is the first thing that I saw from the inconvenient.

ange007 avatar Dec 30 '20 18:12 ange007

We are not duplicating it right? In the pagebuilder config it just calls the env() helper method. However I agree it makes the config a bit clearer when hiding it in the Laravel version of this pagebuilder. I will test it and merge later on. Thanks for your PR.

HansSchouten avatar Jan 07 '21 07:01 HansSchouten