Hans Olsson

Note that Modelica.Mechanics.MultiBody.Frames.Quaternions.der_Orientation already have a corresponding unit. That has two implications: * It is the correct unit; as it cannot be anything else. (Also clear from the constraint that...

Unit consistency for s-parameter in Modelica.Fluid.Vessels.PartialLumpedVessel

4

There are multiple alternatives here, but this seemed like the smallest change. Compare to Modelica.Electrical.Analog.Interfaces.IdealSemiconductor The new indentation of "protected" is consistent with style-guide, previously it was indented less than...

Note that these "parameters" were bound to non-parameter expressions, and that doesn't make sense.

Note that there are some other uses that were deliberately not updated here: - Modelica.Fluid.Dissipation.HeatTransfer.General.kc_approxForcedConvection_KC - Modelica.Fluid.Dissipation.HeatTransfer.Channel.kc_evenGapLaminar_KC - Modelica.Fluid.Dissipation.HeatTransfer.HelicalPipe.kc_laminar_KC - Modelica.Fluid.Dissipation.HeatTransfer.Plate.kc_laminar_KC - Modelica.Fluid.Pipes.BaseClasses.HeatTransfer.LocalPipeFlowHeatTransfer - Modelica.Media.IdealGases.Common.MixtureGasNasa.mixtureViscosityChung - Modelica.Fluid.Dissipation.Utilities.Functions.PressureLoss.TwoPhase.SlipRatio However, if done...

Proper unit for gamma. It is computed as the square root of something.

2

Closes #4369 To confirm I just binged "gamma spice Bulk threshold parameter" and found: https://www.seas.upenn.edu/~jan/spice/spice.MOSparamlist.html which contains the same unit for gamma. And the copilot said: "Its units are Volts^(1/2)."

Modelica.Fluid.Vessels.ClosedVolume roots

1

The model Modelica.Fluid.Vessels.ClosedVolume contains: ``` vesselArea = pi*(3/4*V)^(2/3), heatTransfer(surfaceAreas={4*pi*(3/4*V/pi)^(2/3)})); ``` There is a proposal to introduce the nth root in Modelica that can be used instead of `x^(2/3)` (and help...

Units for gamma in Modelica.Electrical.Spice3.Internal.Mos.mos2CalcCalcTempDependenciesRevised

5

Modelica.Electrical.Spice3.Internal.Mos.mos2CalcCalcTempDependenciesRevised contains: `out_c.m_tVbi := in_p.m_vt0 - in_m_type*(in_p.m_gamma*sqrt(in_p.m_phi)) + ...` The in_m_type is just an integer, but the other variables are all voltages, which mean that we have voltage=voltage+voltage*sqrt(voltage), which clearly...

Issues listed below: - [ ] Using bww as temporary in function? - [ ] Rewrite division to be clearer? - [ ] Or? It started from unit-checking MSL which...

It was changed from 1s to 1e-8s due to https://github.com/modelica/ModelicaStandardLibrary/pull/3625 However, I believe it would be better to simulate to 1e-7s (and also have that in the documentation) - since...

Clarify that a null pointer is an error.

1

Closes #3500