vkd3d-proton icon indicating copy to clipboard operation
vkd3d-proton copied to clipboard

vkd3d: Ensure monotonic frame ID order for Reflex.

Open HansKristian-Work opened this issue 11 months ago • 3 comments

Some applications use app IDs in "random" order which completely breaks the existing implementation.

HansKristian-Work avatar Mar 20 '24 15:03 HansKristian-Work

I gave this a spin. It successfully avoids the slow swapchain-thrashing that was previously reproducible in Spider-Man Miles Morales, Ratchet & Clank, and RoboCop Rogue City.

adamnv avatar Mar 20 '24 18:03 adamnv

@esullivan-nvidia This exposes a bug on NV driver. When IDs aren't one after the other, the algorithm seems to break down. This is especially the case in GetLatencyTimingsNV where the outputs are complete bogus when using stride != 1.

HansKristian-Work avatar Mar 25 '24 11:03 HansKristian-Work

@esullivan-nvidia any updates?

HansKristian-Work avatar Apr 15 '24 12:04 HansKristian-Work

I have submitted the fix for this issue internally. It should ship in the next developer beta driver. I will let you know when that happens.

esullivan-nvidia avatar Apr 16 '24 07:04 esullivan-nvidia

Seems to work on latest beta driver, yes.

HansKristian-Work avatar Apr 25 '24 12:04 HansKristian-Work

LGTM, thanks!

esullivan-nvidia avatar Apr 25 '24 16:04 esullivan-nvidia