vkd3d-proton icon indicating copy to clipboard operation
vkd3d-proton copied to clipboard

Published 20 hours ago • verified publisher icon HansKristian-Work

build: Support custom Wine versions

Open nkeor opened this issue 2 years ago • 2 comments

This allows people to use custom wine versions by exporting the WINE env variable.

If undefined, it uses the $PATH's wine using command -v instead of which. This is POSIX compliant while which isn't, Debian 11 deprecated which.

The changes are the same as https://github.com/doitsujin/dxvk/pull/2617

nkeor avatar Apr 18 '22 19:04 nkeor

  1. Patch is tagged "build: ".. but is it? Maybe "setup: " would be better?
  2. Why is it needed? "Easier than using $PATH variable!"... bit IS it really?
  3. Who really cares what i think :frog:

SveSop avatar Apr 23 '22 21:04 SveSop

  1. The latest commit touching this file has the same tag (https://github.com/HansKristian-Work/vkd3d-proton/commit/1267b2a985e431031220737b653accc09a059c0e)
  2. Yes, for a few custom scripts, exporting PATH is more messy than just pointing WINE to the custom wine

anyway dxvk rejected this patch, so this one's probably going to also 🤷🏻

nkeor avatar Apr 23 '22 21:04 nkeor

Dead PR.

HansKristian-Work avatar Mar 05 '24 12:03 HansKristian-Work