Fix #3537

[jojo2357]

Fix #3537 on how to test.

What was happening was twofold: the casing on extensions was being thrown out at command definition, and when testing different exts, it would also discard the requested casing. This doesnt matter on :window:, because checking for little jpg or big JPG would give the same result from the fs.

[PHPirates]

Thanks! Could you add a test as well?

[jojo2357]

All tests passed locally

[jojo2357]

Ready to go if you are

[jojo2357]

Forgot to mention, #3549 is not fixed here. Do you want to do that here? I was thinking it would need more discussion and refactoring and could be its own PR.

[jojo2357]

Yeah lets tackle the other issue too

[PHPirates]

Yes that can be a separate PR, whatever you want

[jojo2357]

Im stuck on the test where adding an extension with different casing is supposed to ignore the casing if the letters are the same. Makes no sense to me.

[PHPirates]

I'm not sure what you mean, but if you create a PR with a test that is not working properly I might be able to help

[jojo2357]

theres your failing tests

[PHPirates]

Im stuck on the test where adding an extension with different casing is supposed to ignore the casing if the letters are the same. Makes no sense to me.

Now I understand your comment, if you were wondering why extensions were case insensitive: the code was probably written (six years ago) with only Windows in mind. However, even though some things might technically work on Windows I think we should encourage LaTeX that also works on Linux, so that failing test is not something we want to support anymore.

I have one failing test locally because it finds myOtherPicture.png but that file doesn't exist anymore, strange.

[jojo2357]

I have one failing test locally because it finds myOtherPicture.png but that file doesn't exist anymore, strange.

I saw that too. Just occurred to me that I should maybe delete the build dir