Hans Mackowiak
Hans Mackowiak
> @Hanmac there is a `DenormalizerAwareInterface`. > > Dont you think you should both implement DenormalizerAwareInterface and SerializerAwareInterface ? This will avoid to override the phpdoc of setSerializer and avoid...
hm where does it want me to do the psalm thing?
tests are broken, but not by me
curious, the tests are broken on my system ``` assert(): assert(null !== $id) failed /opt/project/src/CmsManager/CmsPageManager.php:174 /opt/project/src/CmsManager/BaseCmsPageManager.php:52 /opt/project/src/CmsManager/CmsPageManager.php:61 /opt/project/tests/CmsManager/CmsPageManagerTest.php:108 assert(): assert(null !== $id) failed /opt/project/src/CmsManager/CmsPageManager.php:174 /opt/project/src/CmsManager/BaseCmsPageManager.php:57 /opt/project/src/CmsManager/CmsPageManager.php:63 /opt/project/tests/CmsManager/CmsPageManagerTest.php:149 assert(): assert(null !==...
that's why i was creating mockup tests before doing this one. (the functions affected by the serializer already have coverage now) but i can try to add more tests to...
yeah i know how to write Functional Tests, i did it for the QueryBuilder updates too Especially when the transformer would touch database stuff. for the Transformer class, i thought...
sounds good, do you want to try it? how exactly does doctrine `type="json"` work there? you probably don't need to serialize the object yourself, but just need the normalizer part...
if really needed, i saw https://symfony.com/doc/4.4/components/serializer.html#built-in-normalizers especially [JsonSerializableNormalizer](https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Serializer/Normalizer/JsonSerializableNormalizer.php) > This means that nested [JsonSerializable](https://secure.php.net/manual/en/class.jsonserializable.php) classes will also be normalized. it might help us to normalize the Block with the Child...
> > if really needed, i saw https://symfony.com/doc/4.4/components/serializer.html#built-in-normalizers especially [JsonSerializableNormalizer](https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Serializer/Normalizer/JsonSerializableNormalizer.php) > > > This means that nested [JsonSerializable](https://secure.php.net/manual/en/class.jsonserializable.php) classes will also be normalized. > > > > > > it...
my thought was that you don't need the serializer when you just normalizing/denormalizing