Hans Mackowiak
Hans Mackowiak
@tool4ever yeah that is my end goal that we don't need "LKICopy" anymore, and have the Effect handle all the stuff
@Agetian maybe you know why on github we don't need to mess with the d8 file?
@tool4ever what exactly is still missing? i thought we ported most of that MR into smaller ones?
> until `noTimestampCheck` contains all API bugs like the one above can still happen oh okay that's what you mean, yeah we should make smaller MR to port all the...
@Agetian can you look to replace `Forge.CURRENT_VERSION` in there: https://github.com/Card-Forge/forge/blob/e2f4c2cfa7a551a215192334bdfc7cfed677b01d/forge-gui-mobile/src/forge/Forge.java#L57 `BuildInfo.getVersionString` ? https://github.com/Card-Forge/forge/blob/e2f4c2cfa7a551a215192334bdfc7cfed677b01d/forge-core/src/main/java/forge/util/BuildInfo.java#L35 that is one of the last pieces where the Version needs to be updated
> Hmm, getVersionString simply returns "GIT" for me (on a snapshot version), with the entire BuildInfo.class.getPackage() method returning "null"... Not sure if it would return a proper version string if...
I think we need https://maven.apache.org/shared/maven-archiver/examples/manifest.html ```xml true ``` i will check this out at weekend
@Agetian the addDefaultImplementationEntries should already be enabled by default when i run `./forge.sh` i already got the correct Forge Version As for the Android thing, i tried: `JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64/ mvn -U...
Linked Issue that is causing the problem: https://github.com/simpligility/android-maven-plugin/issues/814
i think the main problem is this: #3652