Hangfire icon indicating copy to clipboard operation
Hangfire copied to clipboard

Added Queue column to RecurringJobsPage

Open Deantwo opened this issue 7 years ago • 12 comments

This is untested code, but should work in theory.

Added a Queue column to the list of RecurringJobs on the RecurringJobsPage of the dashboard.

Fixes #1189 Might help with issues like #1149 too

Deantwo avatar May 25 '18 09:05 Deantwo

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1bfb550). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1190   +/-   ##
=========================================
  Coverage          ?   68.25%           
=========================================
  Files             ?      155           
  Lines             ?     5116           
  Branches          ?     1075           
=========================================
  Hits              ?     3492           
  Misses            ?     1473           
  Partials          ?      151

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1bfb550...64d1866. Read the comment docs.

codecov-io avatar May 25 '18 09:05 codecov-io

Thanks for your PR! Would you mind to commit updated Strings.Designer.cs and also provide localized strings for other languages (you can simply copy them from corresponding QueuesPage_Table_Queue)?

pieceofsummer avatar May 31 '18 21:05 pieceofsummer

I think that should do it.

Deantwo avatar Jun 07 '18 06:06 Deantwo

@pieceofsummer, merging? For 1.6.20 (master branch) we should ensure that the dashboard page looks fine, for 1.7.0 (dev branch) we can postpone this task to test it later.

odinserj avatar Jun 11 '18 13:06 odinserj

@odinserj this shouldn't break anything, but it is not an urgent change.

We might first merge it into dev (and release the second beta), then merge into master if there are no layout issues because of increased content width.

pieceofsummer avatar Jun 11 '18 13:06 pieceofsummer

@pieceofsummer, sounds good!

odinserj avatar Jun 11 '18 13:06 odinserj

I don't have the time to add it in this pull request, but #1194 might be equally as easy to implement.

Deantwo avatar Jun 11 '18 13:06 Deantwo

@Deantwo unfortunately, it won’t be as easy. There’s no Queue field associated with the Processing state, so it would require either adding it, or extracting from the previous Enqueued state.

pieceofsummer avatar Jun 11 '18 14:06 pieceofsummer

@pieceofsummer nevermind then. Issue just seemed very similar.

Deantwo avatar Jun 11 '18 14:06 Deantwo

So, is this being merged? Or do I need to change anything?

Deantwo avatar Jan 24 '19 09:01 Deantwo

What changed to make those tests fail? This is a very simple little change, so getting it merged would be nice.

I was even missing this feature yesterday.

Deantwo avatar Apr 16 '20 06:04 Deantwo

This isn't getting merged because it would make it more obvious there is a big issue with recurring jobs and queues? Since I just ran head first into the #595 issue myself, and this minor change would make that a lot more obvious.

Deantwo avatar May 15 '20 13:05 Deantwo