HandBrake
1.8 new stop encoding window behaivior
What's the point of the 3rd button in this window?
in 1.7.* you had the "finish current, stop encoding" button, as far as I can remember it was on that position. Now the button makes ghb finishes the current file and starts the next one. Just like "continue encoding" does. Whats the point of this button? Shouldn't it behave like in 1.7.*?
I just verified the functionality with my own encodes. I clicked the button as I had an encode about to finish. It did perform the function of finishing the current encode and stopping. I wonder if this might be a weird mistranslation or something.
Handbrake 1.8.0 using Arch Linux
It did perform the function of finishing the current encode and stopping.
You're right, I tested again (two times with the stop-button in the main window and the one from the queue window) and in both cases it did stop after the current encoding task. I guess I somehow fracked up my initial test.
Ah! So it's a strings error and that 3rd option does exactly what I'd expect.
What does it take to fix this?
I have no idea if this will be accepted, but since it was just a string replacement, I tried to fork and submit a PR to fix the string.