HandBrake
HandBrake copied to clipboard
1.8.0 release planning
There are some fairly large updated contribs that would be nice to have in an official release, plus the GTK4 GUI, hopefully in a few weeks.
Here's a (probably incomplete) list of major things still missing:
- [x] Update translations
- [ ] Update news
- [x] Merge #5923 and #5956
@Nomis101 @robxnano @sr55 @bradleysepos @jstebbins @hnsteyding
Can we also merge https://github.com/HandBrake/HandBrake/pull/4384 ?
I use it regularly. I think @bradleysepos was satisfied with my selection logic. It can be later tweaked if we find corner cases, but I think it's good as it is.
:ballot_box_with_check: Done
This also would be really nice to have https://github.com/HandBrake/HandBrake/pull/5922
:ballot_box_with_check: Done
And hopefully I can look into this issue before release https://github.com/HandBrake/HandBrake/issues/5948
:ballot_box_with_check: Done
I think @bradleysepos was satisfied with my selection logic.
I believe so after re-reading the PR. Though I cannot recall testing it directly, I trust it does what you say it does.
I can make PRs to update all translations, once it is sure that no more new strings will go into 1.8.0.
Probably a good idea to make a note that this is coming on transifex again.
Would somebody be able to update ghb.pot
for gtk, so all the new strings introduced recently will be visible in Transifex, please? This does not work anymore for me, since this process moved to meson.
:ballot_box_with_check: Done
@Nomis101 I was actually just about to do that. I made a pull request: #5959
Probably a good idea to make a note that this is coming on transifex again.
I did so.
Maybe update harfbuzz to 8.4.0 ? #5965
Would somebody be able to update
ghb.pot
for gtk, so all the new strings introduced recently will be visible in Transifex, please? This does not work anymore for me, since this process moved to meson.
I'm not sure how this is meant to be run. I attempted:
cd build/gtk
ninja ghb-pot
And this generated a new gtk/po/ghb.pot
but something isn't correct. It substituted:
-# Copyright (C) 2024 HandBrake Team
+# Copyright (C) YEAR HandBrake Team
So I must be missing an option or configuration somewhere. @robxnano what's the correct way to do this?
Oh, I just edited the year in myself. I don't think there's any way to set the year (or other variables) with xgettext, they're just supposed to be manually added to the .po files by the translators.
What about updating the Flatpak runtime to Gnome 46? It builds fine, just need to check that encoding is working.
What about updating the Flatpak runtime to Gnome 46? It builds fine, just need to check that encoding is working.
Yes please.
Shall we code freeze soon ? :)
Whenever you say is fine by me. I've just been picking some low hanging fruit from our issues list to fix. I can stop at any time :cold_sweat: (says the addict).
Pretend I said nothing ;)
Thanks for merging all the localization PRs. This will give the localizers the opportunity to check how the strings look in the UI. I have noticed there is still some activity ongoing for at least one or two locales to finish the remaining strings, so I plan to do PRs for this new strings beginning or middle of next week (if thats OK).
Sounds good.
Is anything missing from the news?
Looks like we got the bulk of it. Maybe if @bradleysepos has some time to review too?
I should be able to make some time this week.
There are some new (unapproved) patches for x265 regarding AArch64. I am not an expert in this, but at least this two might be useful for us? https://mailman.videolan.org/pipermail/x265-devel/2024-May/013667.html https://mailman.videolan.org/pipermail/x265-devel/2024-May/013672.html For the other 10, I am not sure.
FYI, I'm traveling until next Monday. My time will be limited until then.
@Nomis101 the first looks like only for arm64e, but we compile for the normal arm64 arch, the second probably should be useful, but maybe we can integrate the whole set after they merge it, in the next minor release.
SVT-AV1 2.1 should be out in a week or so, let's wait a bit so we don't ship with an out of date version.
@Nomis101 the first looks like only for arm64e, but we compile for the normal arm64 arch, the second probably should be useful, but maybe we can integrate the whole set after they merge it, in the next minor release.
Thanks for looking into it. This is of course also a good idea. It might just take a while until there is a new x265 release, 3.6 has been 3 years in the making.
Sorry folks,
- Nightly build GUI binary crashes on Windows with 2 Intel GPUs: iGPU + dGPU after selection of H.265 QSV 2160p or AV1 QSV HW presets.
- Nightly CLI binary works fine.
- 1.7.3 GUI also works.
Seems this is regression since we have not contribute anything since 1.7.3 release. I will try to know more details tomorrow.
@sr55 any thoughts?
Found breaking change https://github.com/HandBrake/HandBrake/commit/069b78500eb6bc5c40c0b45e6c4a5cfa047cc049
Reproducible only via GUI
Call stack:
@galad87 are you able to reproduce the crash? Preview function was modified https://github.com/HandBrake/HandBrake/pull/5884/commits/4366cd3615068d2321869010cc8a81d621650058#diff-574ebf6c5d95e912886b84976f946f09a74d7c04c72be275182bafff202f14eaR920
I don't any have QSV hardware ready to use at the moment. I wonder if it's trying to use vpp in the preview format filter for some reason? It would be useful to see where it's crashing in libhb.
Does it happen with a specific source file or with everything?