hanabi-live icon indicating copy to clipboard operation
hanabi-live copied to clipboard

Update getVariantDescriptions.ts

Open gisymon opened this issue 2 years ago • 2 comments

Removing 3-suit variants that are duplicates with Ambiguous combos.

gisymon avatar Jul 02 '22 15:07 gisymon

@timotree3 is this right?

Zamiell avatar Aug 17 '22 15:08 Zamiell

https://github.com/gisymon/hanabi-live/pull/1 to pass lint

vEnhance avatar Aug 17 '22 21:08 vEnhance

@gisymon can you accept the pr?

Zamiell avatar Oct 05 '22 20:10 Zamiell

@vEnhance's PR https://github.com/gisymon/hanabi-live/pull/1 was onto gisymon:main not gisymon:patch-1 so it didn't affect this PR

timotree3 avatar Oct 06 '22 03:10 timotree3

@vEnhance can you just resubmit this as a new PR for gisymon? (since your PR to his PR didn't work)

Zamiell avatar Oct 21 '22 19:10 Zamiell

Let me know if I need to do anything to get this through. Thanks!

gisymon avatar Oct 22 '22 06:10 gisymon

we will merge #2692 after we figure out the problem with the other two PRs

Zamiell avatar Oct 22 '22 07:10 Zamiell