when in hypo, cards can have wrong orientation

[Zamiell]

steps to reproduce:

1. turn on keldon mode
2. start a hypothetical on the turn of someone with cards that do not have a horizontal orientation
3. click and release a card

normally, this would reorient the card back to normal, but since the X/Y positions didn't change, no tween applies

[Zamiell]

i just tested and it appears that PR #2390 did not fix this bug

[DrAnax]

Did you just click and release the card?

Try clicking (hold) and move a bit. Is it working?

[Zamiell]

the bug is that when you move the card, it reorients properly, but when you don't move the card, it does not reorient

[DrAnax]

Ok, that's an old bug, pre-existing the latest changes

[Zamiell]

indeed, the bug does not have anything with your latest changes

[DrAnax]

Mouse up event doesn't fire unless there's a slight move. I think this is a Konva related bug.

[Zamiell]

darn, i guess its unfixable then for now

[Krycke]

Acctually this breaks because of this line: card.layout.rotation(card.layout.parent.rotation() * -1); When we rotate the cards, they leave the mouse event area, and stop firing events from the rotation. We could just remove this line, and everything will work fine.

[Zamiell]

ok, feel free to do a PR then for that

[Krycke]

Ok did some more research. The problem is when we have the mouse event listeners on the card, and then rotate the card.layout. If we only rotate the card, then everything works fine. Problem is that the function to check if "drag to play area" then becomes offsync with the visuall position of the card and the rectangle that is used in the function. And also the rotation back to the hand becomes off, as well as rotation when the card is played. Tried different hacks to figure something out. But didn't manage in a good way. Maybe someone else can continue.