Henk van der Veen comments

Results 17 comments of


                                            Henk van der Veen

strict_variables throws exception on checking if variable exists

I would also like to be able to check if a top-level variable is defined, not just keys on hashes or methods on drops. `{% if defined page %}` feels...

strict_variables throws exception on checking if variable exists

In the end we added our own tag for the top-level variables issue: ```rb module Templating class IfAvailableTag < Liquid::Block def initialize(tag_name, var_name, tokens) super @var_name = var_name end def...

add fact that to_str doesn't do anything anymore for drops to the history.md

@dylanahsmith All of my drops now actually look exactly like this, since only defining to_s broke some of our filters. So shall I make a new PR for the other...

Scrubber removes crucial SVG 1.1 elements

I walked into this as well, but if you use inline svg, the style element is indeed a risk, since it can affect anything on the page. We moved to...

Strange behaviour when file is too big

Workaround is to fileuploadfail instead of s3_upload_failed $('form#fileupload').bind('fileuploadfail', function(e, data) { setTimeout(function() { alert($(data.jqXHR.responseXML).find("Message").text()) }, 0);

Spira.repository unavailable in Rails controller

@abrisse I would like to have a global_repository, since I'm using it as a single readonly dataset for my app.

Add priority method to a job to override the default priority for that job

Looks like it's only rubocop that is failing, because it's using a newer version. I would advice to fix the minor version of rubop, since every minor increase has broken...