Hamlin Li
Hamlin Li
> Let me suggest that we wait for the next release of SLEEF to be released in that case since that release seems to be imminent. That way we'll get...
> Thank you Hamlin. I'll try to keep my eyes open for the announcement of the upcoming SLEEF release but do feel free to notify me if you see it...
Hi @vidmik, Sleef 3.6.1 was just released, https://github.com/shibatch/sleef/releases/tag/3.6.1, which includes the fixes https://github.com/shibatch/sleef/pull/536, https://github.com/shibatch/sleef/pull/537 which fixed the performance issue.
In case you need it and avoid to generate yourself, I've generated sleef inline header of 3.6.1 for riscv, it's at https://github.com/openjdk/jdk/pull/18605/commits/c279a3c290554892939267d9ebe88198988d31a4
@vidmik Thanks for updating, I think I'd better to verify it in case we need uncessary further changes. Will update when I finish.
@vidmik I have verified the tests and performance for aarch64, it's good as before, I also updated related information in https://github.com/openjdk/jdk/pull/18605. Although have some issue for riscv64, but I think...
An quick update, I just verified via QEMU that sleefinline_rvvm1.h works well too.
Hi @vidmik @theRealAph , Just a kindly reminder, could you please bring up the topic (about integrating 3rd party source into jdk, mentioned in [1](https://github.com/openjdk/jdk/pull/18605#issuecomment-2214663777), [2](https://github.com/openjdk/jdk/pull/18605#issuecomment-2230581736)) on workshop or summit?...
> With this solution I would recommend putting the script next to the Sleef source tree instead of in make/devkit/. > The normal JDK build will just use the committed...
@vidmik Thanks for pushing forward this work. Sure, I can take the work. Just several questions, Sorry, as this is the first time I do this kind of work in...