Haled Odat

Results 42 comments of Haled Odat

> Is there anything else missing? Not sure, it should work. I'll debug it when I get some time this week :)

> Also, this design breaks for platforms with pointer size bigger than 48 bits. As far as I know no x86_64 CPU uses the full 64 bits of the pointer...

Proposed changes: - We put our implementation of the console object in an feature flags (maybe `console`/`console-object` flag) this will on by default or not, not sure. - Later on...

If no one is working on this, I'd like to try and solve this :)

> I ended up reading through the links and can see the benefit in doing NaN boxing, however, what is the memory footprint of the fat enum being used currently?...

> If you're looking for impl of NaN boxing in Rust Starlight has two different implementations of them for handling JS values: [https://github.com/Starlight-JS/starlight/blob/dev/crates/starlight/src/vm/value.rs](https://github.com/Starlight-JS/starlight/blob/dev/crates/starlight/src/vm/value.rs?rgh-link-date=2021-07-07T06%3A42%3A40Z) :) Awesome! thanks, for the suggestion. I...

> What about having `ValueVariant` enum which essentially can hold all the values NaN-boxed value can encode and then add `JsValue::variant()` which returns this ValueVariant. I'm pretty sure Rust and...

> @HalidOdat any news on this? Sorry for not replying I have been very busy, but plan to start to do more contributions in the future. I'll start working on...

> At some point (when working on the stack) we will need to operate on objects which are not GC managed. These would be objects that can live on the...