matrix-dotnet-sdk icon indicating copy to clipboard operation
matrix-dotnet-sdk copied to clipboard
verified publisher icon Half-Shot

Is Microsoft.Extensions.Logging 3.0.0-preview.19074.2 necessary?

Open malachib opened this issue 6 years ago • 3 comments

It doesn't seem to be, and is stopping me from compiling a netcore2.2 app

EDIT: I see that the LoggerFactory.Create method is indeed being used, so technically that makes a dependency. Can we find a different way so that we can rely on 2.2 versions of the logger?

malachib avatar Mar 27 '19 07:03 malachib

Yes sure! I will probably switch to a better logger (probs Serilog). I'm going to be a little busy for a while yet, so if you want to go ahead and remove the dependency (I don't think I make extensive use of the logger) and PR it then that would be cool :)

Half-Shot avatar Mar 27 '19 17:03 Half-Shot

I instead encourage to further embrace Microsoft's logger interface (abstract interface only, Serilog underneath is a fine choice) - I'm sure we can make it gracefully live in your environment ! If I have time to do a PR definitely will. I tried removing the dependency, but need to fiddle with the factory more.

Also, separately, hit an issue with Client.Keys, wasn't present so wouldnt compile -- any guidance there?

malachib avatar Mar 27 '19 18:03 malachib

Yeah, it was missing some stuff, commited those.

Half-Shot avatar Mar 28 '19 11:03 Half-Shot