matrix-appservice-twitter icon indicating copy to clipboard operation
matrix-appservice-twitter copied to clipboard

timeline.retweets option

Open erdnaxeli opened this issue 8 years ago • 1 comments

I like to know who have done a retweet. I saw that you add this info in the source message, but it is not shown on Riot. So I propose to add a room option timeline.retweets to select how to show retweeted status:

  • root (the default): show the retweeted status like any other status, this is the current behavior
  • rt: show the status from the user doing the retweet, with RT @user_retweeted: blabla

I've added a column in the timeline_room table to save this parameter.

If the rt parameter is selected, we need to rewrite the the tweet.text field, because the original one can be truncated (and its a badly, truncating even links).

If my not really sure:

  • about the fact of getting the parameter from the db for every tweet
  • about the names root and rt

erdnaxeli avatar Feb 22 '17 22:02 erdnaxeli

about the fact of getting the parameter from the db for every tweet

This is fine. You are unlikely to exceed any disk IO barriers, plus I believe sqlite caches values so it's not a problem.

about the names root and rt

Hmm. That's a tough one. I'd use "default" and "compact"?

Half-Shot avatar Feb 22 '17 23:02 Half-Shot